Update workflows, merge repository kuzzle-containers #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuruyia
suggested changes
Nov 28, 2023
Comment on lines
10
to
12
| NODE_LTS_MAINTENANCE_VERSION: "16" | ||
| NODE_LTS_ACTIVE_VERSION: "18" | ||
| NODE_LTS_CURRENT_VERSION: "20" |
There was a problem hiding this comment.
Why not use a matrix for doing the same thing?
| @@ -20,7 +20,7 @@ jobs: | |||
| steps: | |||
| - id: set-matrix | |||
| run: | | |||
| echo "::set-output name=matrix::{\"node-version\": [\"$NODE_LTS_MAINTENANCE_VERSION\", \"$NODE_LTS_ACTIVE_VERSION\"]}" | |||
| echo "matrix={\"node-version\": [\"$NODE_LTS_MAINTENANCE_VERSION\", \"$NODE_LTS_ACTIVE_VERSION\"]}" >> $GITHUB_OUTPUT | |||
There was a problem hiding this comment.
Is it possible to set up the matrix of Nodejs versions normally (with an array of numbers) instead of constructing it like this? This seems rather "hacky".
There was a problem hiding this comment.
Well, I tried a bunch of thing, seems that this is the way to go if we don't want to repeat the matrix over and over for each jobs
Comment on lines
26
to
27
|
|
||
| WORKDIR /var/app |
There was a problem hiding this comment.
The working directory was already set above.
Suggested change
| WORKDIR /var/app |
Merged
|
Kudos, SonarCloud Quality Gate passed!
|
|
We are going to squash this one 🥶 |
Kuruyia
approved these changes
Nov 29, 2023
fmauNeko
approved these changes
Nov 29, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?