Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger refactor #2539

Draft
wants to merge 2 commits into
base: 2-dev
Choose a base branch
from
Draft

Logger refactor #2539

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16b3e4f
chore(deps): add pino dependencies
fmauNeko Jun 25, 2024
5847f33
feat(core-plugins): remove kuzzle-plugin-logger from core plugins and…
fmauNeko Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .kuzzlerc.sample.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,6 @@
"maxConcurrentPipes": 50,
"pipesBufferSize": 50000,
"include": [
"kuzzle-plugin-logger",
"kuzzle-plugin-auth-passport-local"
]
},
Expand Down
2 changes: 1 addition & 1 deletion lib/config/default.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const defaultConfig: KuzzleConfiguration = {
initTimeout: 10000,
maxConcurrentPipes: 50,
pipesBufferSize: 50000,
include: ["kuzzle-plugin-logger", "kuzzle-plugin-auth-passport-local"],
include: ["kuzzle-plugin-auth-passport-local"],
},
"kuzzle-plugin-logger": {
services: {
Expand Down
5 changes: 1 addition & 4 deletions lib/core/plugin/pluginsManager.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,7 @@ const strategyError = kerror.wrap("plugin", "strategy");
const controllerError = kerror.wrap("plugin", "controller");

// Without those plugins, Kuzzle won't start at all.
const CORE_PLUGINS = [
"kuzzle-plugin-logger",
"kuzzle-plugin-auth-passport-local",
];
const CORE_PLUGINS = ["kuzzle-plugin-auth-passport-local"];

/**
* @class PluginsManager
Expand Down
15 changes: 4 additions & 11 deletions lib/types/config/PluginsConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export type PluginsConfiguration = {
* Edit this list to deactivate one or more of those plugins.
* NOTE: this list does not control plugins installed manually.
*
* @default ["kuzzle-plugin-logger","kuzzle-plugin-auth-passport-local"]
* @default ["kuzzle-plugin-auth-passport-local"]
*/
include: string[];

Expand Down Expand Up @@ -76,23 +76,16 @@ export type PluginsConfiguration = {
};

/**
* Default logger plugin configuration.
*
* This plugin use Winston to transport the logs.
*
* @see https://github.com/kuzzleio/kuzzle-plugin-logger
* Logger plugin configuration.
* @deprecated use server.logs
*/
"kuzzle-plugin-logger": {
/**
* Winston transport services declaration
* Services declaration
*/
services: {
/**
* Print logs to STDOUT
*
* @default
*
* @see https://github.com/winstonjs/winston/blob/master/docs/transports.md#console-transport
*/
stdout: {
/**
Expand Down
Loading
Loading