fix: deployment workflow run rework

[rolljee]

What does this PR do ?

This PR rework the way the deployment workflow runs.

We had an issue where some docker images were not properly tagged. For example, this run of CD should have created the 2.34.0 tag instead of the 2.34.0-beta.1 tag for the plugin-dev.

Turns out, the deployment using semantic was launched at the same time as the deployment docker images.

When semantic release ends the process it makes a commit to update the NPM version of Kuzzle. (You start to see what's coming?)

This commit was not always pushed when the process read the current package.json

      - name: Get current version from package.json
        shell: bash
        id: get-version
        run: |
          echo "version=$(jq -r .version package.json)" >> $GITHUB_OUTPUT
          echo "major-version=$(jq -r .version package.json | cut -d. -f 1)" >> $GITHUB_OUTPUT

Since the package version isn't updated, we still have the -beta.x suffix. Which result in a wrongly tagged docker image.

This PR aim to fix this issue making sure the semantic release process is ended when we start creating all docker images.

How should this be manually tested?

Well, you can't.

Other changes

Nope, nothing

Boyscout

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[fmauNeko]

Is there a specific reason to use ubuntu-20.04 instead of a more recent version ?

[rolljee]

Is there a specific reason to use ubuntu-20.04 instead of a more recent version ?

I made some test trying to fix an issue with npm install. but i found the guilty one. I'll run using ubuntu 24.04 instead

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
5 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[kuzzle]

🎉 This PR is included in version 2.35.0-beta.1 🎉

The release is available on:

• npm package (@beta dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[kuzzle]

🎉 This PR is included in version 2.35.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀