Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: implement pings for websocket on browser #103

Merged
merged 7 commits into from
Jan 22, 2024

Conversation

Kuruyia
Copy link

@Kuruyia Kuruyia commented Dec 22, 2023

What does this PR do ?

This implements periodic pings for the websocket protocol in browser environments.

Other changes

CI has been fixed and dependencies were upgraded. The documentation dead links check has been disabled until we can fix it.
The pubspec.lock file was also removed from the repo as per the recommendations from Dart's developers.

@Kuruyia Kuruyia added the bug Something isn't working label Dec 22, 2023
@Kuruyia Kuruyia self-assigned this Dec 22, 2023
Copy link

@rolljee rolljee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one here @Kuruyia 👍🏼

@Kuruyia Kuruyia merged commit 2400c5f into master Jan 22, 2024
3 checks passed
@Kuruyia Kuruyia deleted the fix/websocket-browser-timeout branch January 22, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants