Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty raw responses parsed as json #731

Merged
merged 3 commits into from
Nov 7, 2023

Conversation

fmauNeko
Copy link
Contributor

@fmauNeko fmauNeko commented Nov 6, 2023

What does this PR do ?

Prevent passing empty strings into JSON.parse when using raw responses over HTTP.

src/protocols/Http.ts Outdated Show resolved Hide resolved
src/protocols/Http.ts Outdated Show resolved Hide resolved
@fmauNeko fmauNeko force-pushed the fix/http-protocol-empty-responses branch from 098eeea to c522bee Compare November 6, 2023 17:57
@fmauNeko fmauNeko requested a review from etrousset November 6, 2023 17:57
Copy link

codecov bot commented Nov 7, 2023

Codecov Report

Merging #731 (feae1d1) into 7-dev (2257670) will decrease coverage by 0.18%.
Report is 14 commits behind head on 7-dev.
The diff coverage is 44.44%.

❗ Current head feae1d1 differs from pull request most recent head 2d99ca6. Consider uploading reports for the commit 2d99ca6 to get more accurate results

@@            Coverage Diff             @@
##            7-dev     #731      +/-   ##
==========================================
- Coverage   83.04%   82.86%   -0.18%     
==========================================
  Files          46       46              
  Lines        2112     2119       +7     
  Branches      408      410       +2     
==========================================
+ Hits         1754     1756       +2     
- Misses        279      282       +3     
- Partials       79       81       +2     
Files Coverage Δ
src/protocols/Http.ts 82.44% <44.44%> (-2.09%) ⬇️

@fmauNeko fmauNeko merged commit 7391b80 into 7-dev Nov 7, 2023
8 checks passed
@fmauNeko fmauNeko deleted the fix/http-protocol-empty-responses branch November 7, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants