fix support for --container-tool-extra-args

README.md

@@ -70,3 +70,10 @@ $ python3 -m fab build --fabfile Fabfile.example
 ```
 
 The above will trigger container image builds in sequence for each of the modules and the final one at the end.
+
+
+Debugging messages can be enabled in fab with the `--log-level debug` switch, and in the underlying podman call with the `--container-tool-extra-args` switch:
+
+```
+$ python3 -m fab --container-tool-extra-args="--log-level debug" --log-level debug  build --fabfile Fabfile.example
+```

fab/cli.py

@@ -79,7 +79,7 @@ def _cmdargs(self):
                             default='/usr/bin/podman')
         parser.add_argument('--container-tool-extra-args',
                             help='container tool extra arguments',
-                            default=[])
+                            default="")
 
         subparsers = parser.add_subparsers(dest='command')
         subparsers.required = False

fab/fab.py

@@ -9,7 +9,7 @@ class Fab:
     Fabfile definition
     """
 
-    def __init__(self, source, container_tool='/usr/bin/podman', tool_args=[]):
+    def __init__(self, source, container_tool='/usr/bin/podman', tool_args=""):
         self.source = source
         self.name = source
         self.container_tool = container_tool
@@ -97,8 +97,7 @@ def build(self):
             tag = '{}-stage-{}'.format(
                 self.name,
                 module.name)
-            podman_args = []
-            podman_args.append(self.tool_args)
+            podman_args = self.tool_args.split()
             podman_args.append('build')
             podman_args.append('--from')
             podman_args.append(previous_container_image)
@@ -114,8 +113,7 @@ def build(self):
             logging.info('Start build of {} stage'.format(tag))
             self._run(self.container_tool, podman_args, module.working_dir)
             previous_container_image = tag
-        podman_args = []
-        podman_args.append(self.tool_args)
+        podman_args = self.tool_args.split()
         podman_args.append('tag')
         podman_args.append(previous_container_image)
         podman_args.append(self.name)