Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert gridsearch vertex workaround #160

Closed
caiw opened this issue Feb 9, 2024 · 0 comments · Fixed by #146
Closed

Revert gridsearch vertex workaround #160

caiw opened this issue Feb 9, 2024 · 0 comments · Fixed by #146
Assignees
Labels
💪 enhancement New feature or request gridsearch Related to the gridsearch

Comments

@caiw
Copy link
Member

caiw commented Feb 9, 2024

#127 introduced the following workaround

          in particular, `gridsearch/plain.py'
            hexels=channel_names[1,:10239], # TODO: HACK - FIX WITH ISSUE #141
            data_lh=log_pvalues_lh[:10239,], # TODO: HACK - FIX WITH ISSUE #141
            data_rh=log_pvalues_rh[:10239,], # TODO: HACK - FIX WITH ISSUE #141

Should be something like:

            hexels=[channel_names[:len(log_pvalues_lh)], len(log_pvalues_lh):],
            data_lh=log_pvalues_lh,
            data_rh=log_pvalues_rh,

_Originally posted by @neukym in https://github.com/kymata-atlas/kymata-toolbox/issues/141#issuecomment-1912923978_
            

This should be reverted once #141 is done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request gridsearch Related to the gridsearch
Projects
None yet
1 participant