Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExpressionSets can be save/loaded from open files, not just paths. #41

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

caiw
Copy link
Member

@caiw caiw commented Nov 3, 2023

(No issue for this.)

Modifies the ExpressionSet.save and .load functions so they can accept an open file handle as an alternative to a path for where to save/load from.

@caiw caiw added 💪 enhancement New feature or request ready-for-merging labels Nov 3, 2023
@caiw
Copy link
Member Author

caiw commented Nov 3, 2023

This change is being used in my review for #34.

@caiw caiw requested a review from neukym November 3, 2023 11:24
@caiw caiw mentioned this pull request Nov 3, 2023
@neukym
Copy link
Member

neukym commented Nov 3, 2023

Look good.

@neukym neukym merged commit ab6fce4 into main Nov 3, 2023
1 check passed
@caiw caiw deleted the save-load-open-files branch November 3, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants