Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused sample data directory. #62

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove unused sample data directory. #62

merged 1 commit into from
Nov 16, 2023

Conversation

caiw
Copy link
Member

@caiw caiw commented Nov 16, 2023 •
edited
Loading

  • The file data/sample-data/sample-config.yaml wasn't being used by anything, so I've removed it (it looks fairly legacy).
  • And I've removed the data directory as it's now empty (though Git deals with empty directories in a weird way).
  • I've also removed some variables which referenced it but, were unreferenced variables. They were made redundant by Creation of a sample datasets fetcher #54.

@caiw caiw requested a review from neukym November 16, 2023 19:18
@caiw
Copy link
Member Author

caiw commented Nov 16, 2023

This relates to #57, though does not close it.

@neukym
Copy link
Member

neukym commented Nov 16, 2023

Agreed.

@neukym neukym merged commit d641d6f into main Nov 16, 2023
1 check passed
@neukym neukym deleted the remote-unused-config-file branch November 16, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neukym neukym Awaiting requested review from neukym

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiw @neukym