Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in tests #99

Merged
merged 2 commits into from
Dec 22, 2023
Merged

bug in tests #99

merged 2 commits into from
Dec 22, 2023

Conversation

caiw
Copy link
Member

@caiw caiw commented Dec 22, 2023

Small bug in tests, this improved test now fails.
I will fix the bug and then merge.

Used the following script:
```python
from zipfile import ZipFile, ZIP_DEFLATED

source = ZipFile('version_0_1.nkg', 'r')
target = ZipFile('version_0_1_fixed.nkg', 'w', ZIP_DEFLATED)
for file in source.filelist:
    targetname = file.filename
    if "layers" in file.filename: continue
    if "set-type" in file.filename: continue
    if "channels" in file.filename:
        targetname = file.filename.replace("channels", "hexels")
    if "version" in file.filename:
        target.writestr(targetname, "0.1")
    else:
        target.writestr(targetname, source.read(file.filename))
target.close()
source.close()
```
@caiw caiw merged commit 836e06f into main Dec 22, 2023
1 check passed
@caiw caiw deleted the improve-test branch December 22, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant