Updated for new API_Key requirements #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Included auth and ssl args for API calling. SSL is not required but useful if you are making these calls over the internet to prevent your auth key being exposed. Added settings on urllib3 to allow for self-signed certs without having to specify location.
Tried to add @wopfel patch without fulling reading it. I really need to slow down and look around :S
This is getting embarrassing....
Pihole Auth update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying this again... Sadly I didn't see the other pull request before making this...
Thought I would still post it as I added SSL option to protect auth_key
It also reports unique_clients... an addition I made a long time ago and forgot about until I committed the new changes. This was just for data tracking, not errors or warnings.
Also updated README to reflect the new args