fix: survey clone error

l3s-learnweb · Nov 7, 2023 · 338007d · 338007d
1 parent e767434
commit 338007d
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/main/java/de/l3s/learnweb/resource/survey/SurveyPage.java b/src/main/java/de/l3s/learnweb/resource/survey/SurveyPage.java
@@ -39,7 +39,7 @@ public SurveyPage(SurveyPage other) {
         setOrder(other.order);
 
         for (SurveyQuestion question : other.getQuestions()) {
-            questions.add(new SurveyQuestion(question));
+            getQuestions().add(new SurveyQuestion(question));
         }
     }
 
@@ -125,10 +125,10 @@ public void setOrder(int order) {
     public List<SurveyQuestion> getQuestions() {
         if (null == questions) {
             if (getId() == 0) {
-                return new ArrayList<>();
+                questions = new ArrayList<>();
+            } else {
+                questions = Learnweb.dao().getSurveyDao().findQuestionsAndOptionsByResourceId(getResourceId(), getId());
             }
-
-            questions = Learnweb.dao().getSurveyDao().findQuestionsAndOptionsByResourceId(getResourceId(), getId());
         }
         return questions;
     }