Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TorchScript tests with regular tests #32

Merged
merged 5 commits into from
Dec 5, 2023

Conversation

agoscinski
Copy link
Collaborator

Hopefully this reduces the testing time significantly

@agoscinski agoscinski force-pushed the merge-torchscript-tests branch 3 times, most recently from 5dba808 to c86c373 Compare September 15, 2023 06:51
@agoscinski
Copy link
Collaborator Author

PR requires fix for metatensor/metatensor#374

@agoscinski
Copy link
Collaborator Author

okay metatensor/metatensor#374 has been fixed. I wait till #31 has been merged and then change metatensor version here and rebase

@agoscinski agoscinski force-pushed the merge-torchscript-tests branch from c86c373 to 82195f6 Compare October 1, 2023 12:59
@agoscinski
Copy link
Collaborator Author

Looking at the CI failure, there seems to be still some kind of memory error

E           ValueError: could not find blocks matching the selection (a_i=0, lam=-1883631648, sigma=21991)

Will look into this some other time.

@Luthaf Luthaf force-pushed the merge-torchscript-tests branch from 471db81 to 0b98742 Compare October 16, 2023 11:46
@Luthaf
Copy link
Contributor

Luthaf commented Oct 16, 2023

Looks fine with the released version of metatensor \o/

@frostedoyster frostedoyster merged commit 7e14342 into master Dec 5, 2023
1 check passed
@frostedoyster frostedoyster deleted the merge-torchscript-tests branch December 5, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants