Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change context indent to handle RPC exception correctly when calling create kernel #2437

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Jul 12, 2024

ai.backend.manager.agent_cache.AgentRPCCache.rpc_context() provides a context with a RPC peer.
It raises a RPCUserError if the RPC invokes error.
We use ai.backend.manager.exceptions.convert_to_status_data() to parse AgentError or MultiAgentError to a readable dictionary but it does not work properly since the function gets only RPCUserError.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

Copy link

graphite-app bot commented Jul 12, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

fregataa commented Jul 12, 2024

@fregataa fregataa force-pushed the topic/fix-context-indent-when-call-create-kernel branch from 5b49ca6 to 6830de1 Compare July 19, 2024 14:27
@fregataa fregataa added the skip:changelog Make the action workflow to skip towncrier check label Jul 19, 2024
@fregataa fregataa added this to the 24.09 milestone Jul 19, 2024
@fregataa fregataa marked this pull request as ready for review July 19, 2024 14:29
@fregataa fregataa added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 62b9faa Jul 19, 2024
38 of 47 checks passed
@fregataa fregataa deleted the topic/fix-context-indent-when-call-create-kernel branch July 19, 2024 14:37
achimnol pushed a commit that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant