feat: Impl Resource sync interface in agent side #2529
Draft
+256
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
This was referenced Jul 22, 2024
fregataa
added
the
skip:changelog
fregataa
force-pushed
the
topic/07-22-feat_implement_resource_sync_interface
branch
3 times, most recently
from
826ec90
to
b590466
Compare
achimnol
requested changes
Aug 8, 2024
| @@ -711,6 +711,19 @@ def check_and_return(self, value: Any) -> set: | |||
| self._failure("value must be Iterable") | |||
|
|
|||
|
|
|||
| class ToList(t.List): | |||
There was a problem hiding this comment.
Could we just reuse trafaret.base.List?
There was a problem hiding this comment.
trafaret.base.List allows list type data only and I want to allow any iterable data type here since sequential data fetched from RPC response get deserialized into tuple.
fregataa
force-pushed
the
topic/07-22-feat_implement_resource_sync_interface
branch
from
b590466
to
ecb36ae
Compare
fregataa
force-pushed
the
topic/07-22-feat_implement_resource_sync_interface
branch
from
ecb36ae
to
82b4f15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agents's sync-and-get-kernels() API
The API that synchronizes agent's kernels to kernel information specified by API parameters (preparing_kernels, pulling_kernels, running_kernels, terminating_kernels). It assumes that the kernel information given by the parameter is the "truth".
If any of kernel information mismatch between kernel_registry and running_kernels(or terminating_kernels), agent injects termination event to terminate the kernel.
sync-and-get-kernels() API returns actual { running, terminating, terminated } kernels (which is not used for now). actual_terminated_kernels contains terminated kernels specified as running_kernels by API parameter.
Checklist: (if applicable)