Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow regular users to assign agent manually when creating sessions #2614

Conversation

lizable
Copy link
Contributor

@lizable lizable commented Aug 2, 2024

related to

hide-agents configuration disallow regular users to get info of agents. When it is set to false, regular users should be allowed to get agent info and assign agents when creating compute sessions.

Checklist:

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • API server-client counterparts (e.g., manager API -> client SDK)

📚 Documentation preview 📚: https://sorna--2614.org.readthedocs.build/en/2614/


📚 Documentation preview 📚: https://sorna-ko--2614.org.readthedocs.build/ko/2614/


📚 Documentation preview 📚: https://sorna--2614.org.readthedocs.build/en/2614/


📚 Documentation preview 📚: https://sorna-ko--2614.org.readthedocs.build/ko/2614/

Copy link
Contributor Author

lizable commented Aug 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC labels Aug 2, 2024
@lizable lizable force-pushed the feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary branch from d746e9f to 66a9b5b Compare November 5, 2024 09:14
@lizable lizable marked this pull request as ready for review November 5, 2024 09:17
@fregataa fregataa added this to the 24.09 milestone Nov 6, 2024
@fregataa fregataa changed the title refactor: apply session allocation at specific agent when hide-agent option is disabled feat: Enable manual agent assignment for regular users when hide-agent is false Nov 6, 2024
@fregataa fregataa changed the title feat: Enable manual agent assignment for regular users when hide-agent is false feat: Enable manual agent assignment for regular users when creating sessions Nov 6, 2024
@fregataa fregataa force-pushed the feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary branch 2 times, most recently from 59bebb7 to 0b4b493 Compare November 13, 2024 09:15
@fregataa fregataa force-pushed the feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary branch from 0b4b493 to e2061be Compare November 22, 2024 06:00
Copy link
Member

@fregataa fregataa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the target milestone 24.09?

@fregataa fregataa changed the title feat: Enable manual agent assignment for regular users when creating sessions fix: Allow regular users to assign agent manually when creating sessions Nov 22, 2024
@fregataa fregataa added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit ea9ea02 Nov 22, 2024
22 checks passed
@fregataa fregataa deleted the feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary branch November 22, 2024 06:40
lablup-octodog pushed a commit that referenced this pull request Nov 22, 2024
…ons (#2614)

Co-authored-by: Sanghun Lee <[email protected]>
Backported-from: main (24.12)
Backported-to: 24.09
Backport-of: 2614
github-merge-queue bot pushed a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants