-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Allow regular users to assign agent manually when creating sessions #2614
Merged
fregataa
merged 8 commits into
main
from
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
Nov 22, 2024
Merged
fix: Allow regular users to assign agent manually when creating sessions #2614
fregataa
merged 8 commits into
main
from
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
Nov 22, 2024
+27
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
area:docs
Documentations
comp:manager
Related to Manager component
size:S
10~30 LoC
labels
Aug 2, 2024
lizable
force-pushed
the
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
branch
from
November 5, 2024 09:14
d746e9f
to
66a9b5b
Compare
fregataa
changed the title
refactor: apply session allocation at specific agent when hide-agent option is disabled
feat: Enable manual agent assignment for regular users when hide-agent is false
Nov 6, 2024
fregataa
changed the title
feat: Enable manual agent assignment for regular users when hide-agent is false
feat: Enable manual agent assignment for regular users when creating sessions
Nov 6, 2024
fregataa
force-pushed
the
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
branch
2 times, most recently
from
November 13, 2024 09:15
59bebb7
to
0b4b493
Compare
…option is disabled
… 'hide-agent' is true
.fix.md -> 2614.fix.md
fregataa
force-pushed
the
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
branch
from
November 22, 2024 06:00
0b4b493
to
e2061be
Compare
fregataa
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the target milestone 24.09?
fregataa
changed the title
feat: Enable manual agent assignment for regular users when creating sessions
fix: Allow regular users to assign agent manually when creating sessions
Nov 22, 2024
fregataa
deleted the
feature/enable-session-allocation-at-specific-agent-when-user-can-access-to-agent-summary
branch
November 22, 2024 06:40
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ons (#2614) Co-authored-by: Sanghun Lee <[email protected]> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 2614
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 22, 2024
…ons (#2614) (#3132) Co-authored-by: Jihyun Kang <[email protected]> Co-authored-by: Sanghun Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to
hide-agents
configuration disallow regular users to get info of agents. When it is set to false, regular users should be allowed to get agent info and assign agents when creating compute sessions.Checklist:
📚 Documentation preview 📚: https://sorna--2614.org.readthedocs.build/en/2614/
📚 Documentation preview 📚: https://sorna-ko--2614.org.readthedocs.build/ko/2614/
📚 Documentation preview 📚: https://sorna--2614.org.readthedocs.build/en/2614/
📚 Documentation preview 📚: https://sorna-ko--2614.org.readthedocs.build/ko/2614/