feat: Implement check-and-pull mechanism for session creation lifecycle #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:docs
This was referenced Aug 16, 2024
This stack of pull requests is managed by Graphite. Learn more about stacking. |
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
913c5b1
to
4d6c7c0
Compare
fregataa
changed the title
check-and-pull mechanism to session creation lifecycle
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
e777812
to
186819e
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
4d6c7c0
to
b2640fc
Compare
This was referenced Aug 19, 2024
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
186819e
to
72350c8
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
b2640fc
to
fbe61c2
Compare
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
72350c8
to
0927a15
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
fbe61c2
to
2ad51d8
Compare
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
0927a15
to
2dbab11
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
2ad51d8
to
5fac8cc
Compare
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
03030bd
to
e054703
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
2 times, most recently
from
f3976df
to
66a1cbb
Compare
fregataa
force-pushed
the
topic/08-10-feat_add_check-and-pull_rpc_function
branch
from
e054703
to
c26d5ee
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
66a1cbb
to
0621dbb
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
61fa41f
to
1cf8073
Compare
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
1cf8073
to
22258b1
Compare
3 tasks
…ms rather than flag
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
22258b1
to
b5741af
Compare
Comment on lines
299
to
+301
| load_aliases=False, | ||
| *, | ||
| loading_options: Iterable[RelationLoadingOption] = tuple(), |
There was a problem hiding this comment.
write a issue to refactor this bool flag
Comment on lines
+3281
to
+3283
| (KernelRow.image == image) | ||
| & (KernelRow.agent == agent_id) | ||
| & (KernelRow.status == KernelStatus.SCHEDULED) |
fregataa
force-pushed
the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
from
0b24b49
to
3ce06ff
Compare
fregataa
deleted the
topic/08-16-feat_apply_check-and-pull_mechanism_to_session_creation_lifecycle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #2276 (Step 2)
As is
Pending -> Scheduled -> Preparing (-> Pulling) -> Running -> ...
To do
Pending -> Scheduled -> Preparing (-> Pulling) -> Prepared -> Preparing(After #3114 Creating) -> Running -> ...
Checklist: (if applicable)
docsdirectory📚 Documentation preview 📚: https://sorna--2721.org.readthedocs.build/en/2721/
📚 Documentation preview 📚: https://sorna-ko--2721.org.readthedocs.build/ko/2721/