-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Broken ComputeContainer
GQL
#3042
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Related to Manager component
size:XS
~10 LoC
labels
Nov 7, 2024
jopemachine
added
type:bug
Reports about that are not working
and removed
comp:manager
Related to Manager component
size:XS
~10 LoC
labels
Nov 7, 2024
fregataa
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This cannot resolve query like below
query ComputeContainer {
compute_container (
id: "KERNEL_ID"
){
id
image_object {
id
name
}
}
}
.fix.md -> 3042.fix.md
Resolved in c7c7707 |
jopemachine
added
action:on hold
Hold it. Wait for the restart.
and removed
action:on hold
Hold it. Wait for the restart.
labels
Nov 9, 2024
achimnol
approved these changes
Nov 11, 2024
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 24.09 Backport-of: 3042
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 24.03 Backport-of: 3042
lablup-octodog
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 23.09 Backport-of: 3042
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Gyubong Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Co-authored-by: Gyubong Lee <[email protected]> Co-authored-by: Joongi Kim <[email protected]>
1 task
achimnol
added a commit
that referenced
this pull request
Nov 17, 2024
Co-authored-by: Joongi Kim <[email protected]> Backported-from: main (24.12) Backported-to: 23.09 Backport-of: 3042
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:manager
Related to Manager component
size:XS
~10 LoC
type:bug
Reports about that are not working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using
ComputeContainer
GQL, the following error occurs.This PR fixes this bug by removing part of the optimization in
ComputeContainer.batch_load_detail()
that retrievesKernelRow
.Checklist: (if applicable)