Fix issue #2694 #2702
Open
Fix issue #2694 #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldas
requested changes
Nov 22, 2024
There was a problem hiding this comment.
Tests are missing.
Are you sure that this implementation is correct? I am looking at https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Forwarded#using_the_forwarded_header and the header values are quite complex Forwarded: by=<identifier>;for=<identifier>;host=<host>;proto=<http|https> Where is that proto part parsing is done?
|
This seems so complex that it is maybe worth being separate middleware. Because if you change |
|
That's right, I'll try to fix this problem and make another commit, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Fix issue #2694 and add "Forwarded"