-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added silence_level_analysis (sla) for easier deciding of silence level #25
base: master
Are you sure you want to change the base?
Conversation
This is an awesome idea, this will definitely be part of the next big release. I have to more ideas that will probably make this even better:
What do you think about that? |
Hi, I like your improved ideas very much. Hadn't thought of having a low, normal, high, full version. That would be quite comprehensive and nice. I'll work on them tomorrow along with one feature I was thinking of - If someone uses unsilence and there is no difference in output video (0.00% delta for all audible, silence and combined), then it would suggest to use sla so that user can choose a correct silence level value. (Edit: By suggest, I mean having a choice dialog). |
Great idea! I'm looking forward to your update! Do you think it is necessary to also add these features to the python library? |
Hi, I don't think it's necessary in the library. As you said, it should be easy for user to implement this in their code if they use the library. I would not want to unnecessarily bloat the code either. I've added the features that we discussed in the latest commit.
|
Hey, thanks for your great work 😀 I'm going to look over the changes later this day and merge it into the next release branch. I will also probably add a lru cache to the silence calculation in order to avoid executing the function again with the same parameters (caching would be a big speed up compared to a rerun) |
It is a bit time consuming to test silence levels for videos by repeatedly entering different silence level commands , and some videos I used unsilence on had 0 difference using the default -35 silence level, so I thought of creating a table with multiple silence levels that would make good reference for user to decide what the silence level should be. Can be easily expanded by just changing the list values.
Here’s a short video demo of how it works on my Win10:
https://www.youtube.com/watch?v=raWyQhvf4WI&feature=youtu.be