Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Navigation View Helpers #259

Open
wants to merge 1 commit into
base: 3.0.x
Choose a base branch
from
Open

Remove Navigation View Helpers #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,7 @@
"laminas/laminas-modulemanager": "^2.17",
"laminas/laminas-mvc": "^3.8.0",
"laminas/laminas-mvc-i18n": "^1.9",
"laminas/laminas-navigation": "^2.20.0",
"laminas/laminas-paginator": "^2.19.0",
"laminas/laminas-permissions-acl": "^2.16",
"laminas/laminas-router": "^3.14.0",
"laminas/laminas-uri": "^2.12",
"phpunit/phpunit": "^10.5.38",
Expand Down
150 changes: 4 additions & 146 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 9 additions & 0 deletions docs/book/v3/migration/v2-to-v3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,3 +101,12 @@ To encode data to Json for output in a view, you can call [`json_encode`](https:

If you were relying on behaviour that was previously available via `laminas-json`, for example, calling object methods `toArray` or `toJson` prior to encoding, you should make the relevant objects implement `JsonSerializable`.
You can find documentation on the `JsonSerializable` interface [on the PHP website](https://www.php.net/manual/class.jsonserializable.php).

#### Navigation

The deprecated navigation view helpers such as `Breadcrumbs`, and `Menu` etc have been removed and can now be found in [the `laminas-navigation` component](https://docs.laminas.dev/laminas-navigation/helpers/intro/).

As such, the namespace for these helpers has changed from `Laminas\View\Navigation` to `Laminas\Navigation\View\Helper`, so if you have referenced the FQCNs of these helpers in your code, you will need to update them accordingly.

At the time of writing, the `laminas-navigation` 2.x series of releases is not compatible with `laminas-view` 3.x and a major release of the `laminas-navigation` component is not available.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it help or be easier if we moved the helpers to a separate package? The original plans included the support of different template systems, laminas-view would be one of them.

If you rely on the navigation helpers, you will have to wait for a compatible release of `laminas-navigation` before you can upgrade to `laminas-view` version 3.0.
Loading