🐛 Fix transfering artifacts from a source instance with fewer schema modules #2132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falexwolf
changed the title
falexwolf
reviewed
Nov 5, 2024
tests/storage/test_transfer.py
Outdated
| @@ -100,8 +100,17 @@ def test_transfer_from_remote_to_local(): | |||
| assert artifact2.organisms.get(name="mouse") == bt.settings.organism | |||
| assert artifact.features["obs"].get(name="organism").uid == "existing" | |||
|
|
|||
| # test transfer form a remote instance with less schema modules to a local instance (laminlabs/lamin-site-assets) | |||
There was a problem hiding this comment.
It should be called "source instance" and "fewer schema modules than target instance".
"local" and "remote" aren't relevant concepts here.
|
We are running at the same time. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2132 +/- ##
==========================================
+ Coverage 92.53% 92.56% +0.03%
==========================================
Files 55 55
Lines 6467 6469 +2
==========================================
+ Hits 5984 5988 +4
+ Misses 483 481 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2117