Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Improve saving validated output #2140

Merged
merged 3 commits into from
Nov 7, 2024
Merged

🎨 Improve saving validated output #2140

merged 3 commits into from
Nov 7, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 7, 2024

Fixes #2110

  • Moves the logging to a more scoped internal function to ensure that only if there's validated values a logging message is printed
  • More consistent logging with quotes
  • Now always logging "saving record" instead of "saving term".
Before After
Before Image After Image

@Zethson Zethson marked this pull request as ready for review November 7, 2024 12:09
Copy link

github-actions bot commented Nov 7, 2024

@Zethson Zethson requested a review from sunnyosun November 7, 2024 12:17
Copy link
Member

@sunnyosun sunnyosun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.59%. Comparing base (57fbd29) to head (7515fd2).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2140      +/-   ##
==========================================
+ Coverage   92.53%   92.59%   +0.06%     
==========================================
  Files          55       55              
  Lines        6467     6472       +5     
==========================================
+ Hits         5984     5993       +9     
+ Misses        483      479       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 12:29 Inactive
@Zethson Zethson merged commit 856fd44 into main Nov 7, 2024
16 checks passed
@Zethson Zethson deleted the fix/repeated_logging branch November 7, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated validate() calls result in repeated stdout of saving validated terms of XYZ
2 participants