Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Warn if curating against gene symbols #2142

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Nov 7, 2024

Fixes laminlabs/bionty#143

  • Adds a warning if the var_index is bt.Gene.symbol to check out the FAQ for more details on why this is bad
  • I decided against hard coding a URL because it can change.
  • I decided against adding this warning in curate() because it would get triggered repeatedly which can be annoying

@Zethson Zethson marked this pull request as ready for review November 7, 2024 14:02
Signed-off-by: zethson <[email protected]>
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (57fbd29) to head (4624ae9).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2142      +/-   ##
==========================================
+ Coverage   92.53%   92.60%   +0.06%     
==========================================
  Files          55       55              
  Lines        6467     6474       +7     
==========================================
+ Hits         5984     5995      +11     
+ Misses        483      479       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Zethson Zethson merged commit c3c0ab5 into main Nov 7, 2024
15 checks passed
@Zethson Zethson deleted the feature/symbol_mapping_warning branch November 7, 2024 14:49
Copy link

github-actions bot commented Nov 7, 2024

@github-actions github-actions bot temporarily deployed to pull request November 7, 2024 14:51 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be more opinionated about mapping symbols vs ensembl IDs
1 participant