-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎨 Separate labels fetching from printing #2225
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2225 +/- ##
==========================================
+ Coverage 92.36% 92.91% +0.54%
==========================================
Files 54 54
Lines 6566 6650 +84
==========================================
+ Hits 6065 6179 +114
+ Misses 501 471 -30 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me! I'm a bit worried about lack of testing but I think this should be good.
I've added a more comprehensive test for description in the following PR:
But given it doesn't yet pass we can't use it to see whether this here introduces any problems. 😔
No description provided.