Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Separate labels fetching from printing #2225

Merged
merged 6 commits into from
Nov 28, 2024
Merged

🎨 Separate labels fetching from printing #2225

merged 6 commits into from
Nov 28, 2024

Conversation

sunnyosun
Copy link
Member

No description provided.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 92.98246% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.91%. Comparing base (c54f99f) to head (2cf108e).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/core/_label_manager.py 92.59% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2225      +/-   ##
==========================================
+ Coverage   92.36%   92.91%   +0.54%     
==========================================
  Files          54       54              
  Lines        6566     6650      +84     
==========================================
+ Hits         6065     6179     +114     
+ Misses        501      471      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 28, 2024

@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 10:50 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 14:53 Inactive
@sunnyosun sunnyosun requested a review from falexwolf November 28, 2024 15:22
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request November 28, 2024 15:46 Inactive
Copy link
Member

@falexwolf falexwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I'm a bit worried about lack of testing but I think this should be good.

I've added a more comprehensive test for description in the following PR:

But given it doesn't yet pass we can't use it to see whether this here introduces any problems. 😔

@sunnyosun sunnyosun merged commit ec37354 into main Nov 28, 2024
16 checks passed
@sunnyosun sunnyosun deleted the labels-print branch November 28, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants