Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix IPython import error #2250

Merged
merged 1 commit into from
Dec 3, 2024
Merged

🐛 Fix IPython import error #2250

merged 1 commit into from
Dec 3, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Dec 3, 2024

Do not import IPython directly in .view.py

@Koncopd
Copy link
Member Author

Koncopd commented Dec 3, 2024

@falexwolf you added display_df_with_descriptions here. The problem is that it doesn't really check if IPython is present like in other parts of the code in the file. I have just moved the imports inside the function but i think we also need a variant of display_df_with_descriptions without IPython, but just for a terminal, i.e. printing without html.

Copy link

github-actions bot commented Dec 3, 2024

@github-actions github-actions bot temporarily deployed to pull request December 3, 2024 20:47 Inactive
@Koncopd Koncopd merged commit 6096eb8 into main Dec 3, 2024
14 checks passed
@Koncopd Koncopd deleted the fix_ipython_import branch December 3, 2024 20:47
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.89%. Comparing base (4c27162) to head (87e9bb0).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
+ Coverage   92.71%   92.89%   +0.17%     
==========================================
  Files          55       55              
  Lines        6947     7165     +218     
==========================================
+ Hits         6441     6656     +215     
- Misses        506      509       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant