Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Allow to register artifacts with http urls #2291

Merged
merged 5 commits into from
Dec 17, 2024
Merged

✨ Allow to register artifacts with http urls #2291

merged 5 commits into from
Dec 17, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Dec 17, 2024

Related laminlabs/lamindb-setup#913

This PR enables to register http and https links as artifacts.

secondary_analysis = ln.Artifact(
    "https://assets.hubmapconsortium.org/1d91e74d48a309724ede35bdb33b5eb2/secondary_analysis.h5ad",
    key="hubmap/HBM543.LFFX.573/secondary_analysis.h5ad",
    description = "Normalized gene expression with additional metadata, in HDF5 format, readable with the 'anndata' Python package (Format: EDAM_1.24.format_3590)"
).save()
secondary_analysis.load()
secondary_analysis.open()

See also https://lamin.ai/laminlabs/lamindata/transform/Wa7Fep0r3Hwp0000

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (2a17099) to head (a71cb9c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2291      +/-   ##
==========================================
+ Coverage   92.82%   92.85%   +0.03%     
==========================================
  Files          55       55              
  Lines        7202     7212      +10     
==========================================
+ Hits         6685     6697      +12     
+ Misses        517      515       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 17, 2024

@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 11:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 12:15 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 13:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 17, 2024 16:40 Inactive
@Koncopd Koncopd merged commit 76f1d1f into main Dec 17, 2024
16 checks passed
@Koncopd Koncopd deleted the http_register branch December 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant