Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Only auto-search ._name_field on sub-classes of CanCurate #2319

Merged
merged 4 commits into from
Jan 4, 2025

Conversation

falexwolf
Copy link
Member

@falexwolf falexwolf commented Jan 3, 2025

Before After
image image

We're currently using the ._name_field not only as display field, but also to govern auto-search when creating new records.

This isn't meaningful for registries like ParamValue, FeatureValue, Run, Transform, Artifact and others.

Hence, from now on, we only perform the search on sub-classes of CanCurate.

There is a bigger question on when a name field should imply uniqueness (hard on the SQL level or soft via auto-search on the Python level). See more in this internal Slack ref and this issue:

@falexwolf falexwolf changed the title Paramvalue 🚸 Only auto-search ._name_field on sub-classes of CanCurate Jan 3, 2025
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.73%. Comparing base (2a17099) to head (acbaf72).
Report is 22 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2319      +/-   ##
==========================================
- Coverage   92.82%   85.73%   -7.09%     
==========================================
  Files          55       80      +25     
  Lines        7202     8548    +1346     
==========================================
+ Hits         6685     7329     +644     
- Misses        517     1219     +702     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 4, 2025

@github-actions github-actions bot temporarily deployed to pull request January 4, 2025 00:29 Inactive
@falexwolf falexwolf merged commit 79e0b74 into main Jan 4, 2025
16 of 17 checks passed
@falexwolf falexwolf deleted the paramvalue branch January 4, 2025 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant