🚸 Only auto-search ._name_field
on sub-classes of CanCurate
#2319
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're currently using the
._name_field
not only as display field, but also to govern auto-search when creating new records.This isn't meaningful for registries like
ParamValue
,FeatureValue
,Run
,Transform
,Artifact
and others.Hence, from now on, we only perform the search on sub-classes of
CanCurate
.There is a bigger question on when a name field should imply uniqueness (hard on the SQL level or soft via auto-search on the Python level). See more in this internal Slack ref and this issue:
name
field of most registries #2269