Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure float operations in SoundSynthesizerEffects & CompassCalibrator. #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

microbit-carlos
Copy link
Collaborator

@microbit-carlos microbit-carlos commented Nov 25, 2024

Related PR, which includes files in codal-core like LevelDetectorSPL, and together with this PR it saves >400 bytes of flash:

Edit: Also ensured float literals in a couple of other files to avoid implicit double promotion.

Copy link

github-actions bot commented Nov 25, 2024

Note

This build diff was generated when this branch included for testing commit 5c04d7c , which updates codal-core in target-locked.json to the commit from PR lancaster-university/codal-core#176, and it shows dropping log10() completely for log10f(), which results in almost half a KB of flash savings.

This was reverted and the "real" build diff can be seen in #454 (comment).

Build diff

Base commit: 6ac8666c0100b19551ddb7c2acf007b8950fe9b3
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/12017300166

    VM SIZE    
-------------- 
 +1.9%     +24    /home/runner/work/codal-microbit-v2/codal-microbit-v2/libraries/codal-core/source/streams/LevelDetectorSPL.cpp
 -2.1%    -488    [section .text]
 -0.1%    -464    TOTAL

Also ensure float literals are used in other files to avoid
implicity double promotion.
Copy link

Build diff

Base commit: 6ac8666c0100b19551ddb7c2acf007b8950fe9b3
Action run: https://github.com/lancaster-university/codal-microbit-v2/actions/runs/12036161069

     VM SIZE    
 -------------- 
  [ = ]       0    TOTAL

@microbit-carlos microbit-carlos changed the title Ensure float operations in SoundSynthesizerEffects. Ensure float operations in SoundSynthesizerEffects & CompassCalibrator. Nov 26, 2024
@lancaster-university lancaster-university deleted a comment from github-actions bot Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant