feat: support IVF_FLAT and hamming in pylance #3301
+55
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BubbleCal <[email protected]>
Signed-off-by: BubbleCal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3301 +/- ##
==========================================
+ Coverage 78.96% 79.02% +0.06%
==========================================
Files 246 246
Lines 87589 87589
Branches 87589 87589
==========================================
+ Hits 69164 69219 +55
+ Misses 15558 15506 -52
+ Partials 2867 2864 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eddyxu
reviewed
Dec 31, 2024
| @@ -1869,24 +1869,19 @@ def create_index( | |||
| f" ({num_sub_vectors})" | |||
| ) | |||
|
|
|||
| if not pa.types.is_floating(field.type.value_type): | |||
There was a problem hiding this comment.
can we check floating and int8/uint8 here?
Signed-off-by: BubbleCal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.