Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INTPYTHON-270 Implement a MongoDB record manager #42

Merged
merged 12 commits into from
Dec 17, 2024
Merged

INTPYTHON-270 Implement a MongoDB record manager #42

merged 12 commits into from
Dec 17, 2024

Conversation

blink1073
Copy link
Collaborator

@blink1073 blink1073 commented Dec 17, 2024 •
edited
Loading

Use run_in_executor uniformly for now so we don't need to depend on motor. Once we finish async pymongo we can use that instead.

caseyclements
caseyclements approved these changes Dec 17, 2024
View reviewed changes
Copy link
Collaborator

@caseyclements caseyclements left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Had a thorough review.

@blink1073 blink1073 merged commit e6e38a3 into langchain-ai:main Dec 17, 2024
9 checks passed
@blink1073 blink1073 deleted the INTPYTHON-270 branch December 17, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caseyclements caseyclements caseyclements approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blink1073 @caseyclements