feat(graph): passthrough input types to invoke/stream #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
previously approved these changes
Nov 2, 2024
…e for correct semantics, use Annotation.Root for prebuilt agent executor
dqbd
commented
Nov 4, 2024
| > { | ||
| declare NodeType: N; | ||
|
|
||
| declare RunInput: RunInput; | ||
| declare RunInput: State; |
There was a problem hiding this comment.
It's a little strange that RunInput = StateType<SD>, I think we should change it to Update?
There was a problem hiding this comment.
Yea I agree, this looks to be the other way around, no? input should be update, output should be based on stream mode (sometimes update, sometimes state, etc)
dqbd
commented
Nov 4, 2024
| const workflow = new StateGraph<AgentState>({ | ||
| channels: schema, | ||
| }) | ||
| const workflow = new StateGraph(MessagesAnnotation) |
There was a problem hiding this comment.
This is done primarily to get the correct input types (based off the messagesReducer, but open to different solutions.
There was a problem hiding this comment.
I think it's good to make this change, the other syntax is deprecated
dqbd
commented
Nov 4, 2024
| @@ -3541,6 +3541,7 @@ export function runPregelTests( | |||
| hello: "there", | |||
| bye: "world", | |||
| messages: ["hello"], | |||
| // @ts-expect-error This should emit a TS error | |||
There was a problem hiding this comment.
We can now actually catch excessive keys!
dqbd
changed the title
nfcampos
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opting to fix output types in a different PR due to the complexity of
streamModeCloses #628