[pt] More verbs/nouns fixes in disambiguation.xml #11073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe pull request introduces extensive modifications to the Changes
Possibly related issues
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (3)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml (3)
3933-3957: Consider adding more test examples for the disambiguation rules.The rule groups for handling verb disambiguation look good, but would benefit from more comprehensive test examples to ensure proper coverage of edge cases.
Consider adding examples like:
<example type="ambiguous" inputform="pode[podar/VMM03S0,poder/VMIP3S0]" outputform="pode[poder/VMIP3S0]">Ele não <marker>pode</marker> fazer isso.</example> <example type="untouched">Ele <marker>poda</marker> as plantas.</example>
Line range hint
3933-4024: Optimize pattern matching in verb disambiguation rules.The rules for handling verb/noun disambiguation are well-structured but could be optimized for better performance.
Consider these optimizations:
- Combine similar pattern matches using the
|operator- Use more specific postag patterns where possible
- Consider adding
<antipattern>blocks for common false positivesExample optimization:
-<token postag="VMSP3S0|VMIP3S0|VMM02S0|VMSP2S0|VMIP2S0|VMN02S0|VMSF2S0" postag_regexp="yes"/> +<token postag="VM[SIM][PIF][23]S0|VMN02S0" postag_regexp="yes"/>
Line range hint
1-4024: Enhance rule documentation for better maintainability.While the code is well-organized, some rules would benefit from more detailed documentation explaining:
- The linguistic rationale behind the rule
- Examples of what the rule catches and doesn't catch
- Any known limitations or edge cases
Consider adding structured comments like this before complex rules:
<!-- Rule: REMOVE_PODAR_FROM_MODAL_PODER Purpose: Disambiguates between 'podar' (to prune) and 'poder' (can/may) Context: When 'poder' is used as a modal verb followed by an infinitive Example matches: - "pode fazer" -> poder (can do) - "pode estar" -> poder (may be) Non-matches: - "poda as plantas" -> podar (prunes the plants) Known limitations: - May need special handling for reflexive verbs -->
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/resource/pt/disambiguation.xml(1 hunks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes.
Summary by CodeRabbit
New Features
Bug Fixes
These changes significantly improve the language processing capabilities for Portuguese, ensuring more accurate grammar checks.