Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pt] Added AP to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11075

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

marcoagpinto
Copy link
Member

@marcoagpinto marcoagpinto commented Dec 1, 2024

Just an antipattern to fix false positives.

Summary by CodeRabbit

  • New Features
    • Introduced a new antipattern for the phrase "álbuns solo" in the Portuguese language module to enhance grammar checking.
    • Added example sentences to illustrate the usage of the new antipattern.

Copy link
Contributor

coderabbitai bot commented Dec 1, 2024

Walkthrough

The pull request introduces a new antipattern entry in the grammar.xml file for the Portuguese language module. It specifically addresses the phrase "álbuns solo" and includes three <token> elements that define the grammatical structure and conditions for this antipattern. The entry maintains consistency with existing formats and provides example sentences to illustrate the usage of the antipattern.

Changes

File Path Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml Added new <antipattern> for "álbuns solo" with three <token> elements and example sentences.

Possibly related PRs

Suggested reviewers

  • jaumeortola

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

4338-4339: Consider adding more diverse example cases.

While the current examples are good, consider adding examples with different preceding words to demonstrate the full range of the pattern matching. For instance, cases with adjectives or participles before "solo".

Example additions:

  <example>Quero dois álbuns solo.</example>
  <example>Quorthon também produziu dois álbuns solo.</example>
+ <example>Os premiados trabalhos solo do artista...</example>
+ <example>Seus brilhantes projetos solo...</example>
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f1d1de4 and d050441.

📒 Files selected for processing (1)
  • languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

4334-4340: LGTM! Well-structured antipattern for "álbuns solo" case.

The antipattern correctly handles the grammatical case where "solo" remains invariable when used as a musical term, even with plural nouns. The token patterns are comprehensive, covering various parts of speech (adjectives, nouns, numbers, determiners/pronouns, and participles) that might precede "solo".

@marcoagpinto marcoagpinto merged commit 7f4f145 into master Dec 1, 2024
5 checks passed
@marcoagpinto marcoagpinto deleted the lt_marcoagpinto_20241201_1047 branch December 1, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant