-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pt] Added AP to rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #11075
Conversation
WalkthroughThe pull request introduces a new antipattern entry in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
4338-4339
: Consider adding more diverse example cases.While the current examples are good, consider adding examples with different preceding words to demonstrate the full range of the pattern matching. For instance, cases with adjectives or participles before "solo".
Example additions:
<example>Quero dois álbuns solo.</example> <example>Quorthon também produziu dois álbuns solo.</example> + <example>Os premiados trabalhos solo do artista...</example> + <example>Seus brilhantes projetos solo...</example>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml
(1 hunks)
🔇 Additional comments (1)
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)
4334-4340
: LGTM! Well-structured antipattern for "álbuns solo" case.
The antipattern correctly handles the grammatical case where "solo" remains invariable when used as a musical term, even with plural nouns. The token patterns are comprehensive, covering various parts of speech (adjectives, nouns, numbers, determiners/pronouns, and participles) that might precede "solo".
Just an antipattern to fix false positives.
Summary by CodeRabbit