Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material centric2 #213

Merged
merged 20 commits into from
Aug 7, 2024
Merged

Material centric2 #213

merged 20 commits into from
Aug 7, 2024

Conversation

nathanielmorgan
Copy link
Collaborator

@nathanielmorgan nathanielmorgan commented Aug 5, 2024

Description

The new material centric implementation is up and running on CPUs and GPUs. This version loops over the elements in the mesh that have a material (key to eliminating thread divergence). The material centric data structures also allow developers to append data to the end of the material storage, key for any future remap research (for ALE) or future Eulerian AMR research. The coding also solves an energy equation per material.

This version also renames variables (more of them) according to the google style guide and reorganizes the files for cleanliness.

Type of change

Please select all relevant options

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Formatting and/or style fixes
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran tests on CPUs and GPUs

  • Sedov :
  • Sedov-origin-erosion :
  • impact-erosion :

Test Configuration:

  • OS version: Mac OS

  • Hardware: x86 CPU and NVidia GPU

  • Compiler: clang with openMP backend

  • OS version: Linux,

  • Hardware: x86 CPU with a V100 GPU

  • Compiler: gcc plus CUDA

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [0] My changes generate a few cuda warnings about unused variables, those variables for needed
  • The code builds from scratch with my new changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jacob-moore22
Copy link
Collaborator

Just a note to any reviewers. We changed the cmake to do a more monolithic build because we were having issues with compilation. In the end, our issues were probably not from creating libraries and then linking them. We may revert back at some point, but only after further consideration and changes to how we handle everything in the "Common" directory.

Copy link
Collaborator

@jacob-moore22 jacob-moore22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathanielmorgan
Copy link
Collaborator Author

Material centric implementation

@nathanielmorgan nathanielmorgan merged commit cf29007 into main Aug 7, 2024
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants