Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parquet unit tests. Add static html generator output for parquet front end. #84

Merged
merged 7 commits into from
Jan 25, 2024

Conversation

qwofford
Copy link
Collaborator

Resolves #81 and #82.

@qwofford qwofford self-assigned this Dec 21, 2023
@qwofford
Copy link
Collaborator Author

Also closes #85 .

Note that my set of software requirments is generated from conda list --export, and it is more verbose than we likely need. If this causes issues we should remove the offending lines. It works for me on multiple platforms and OS distributions, so I'm inclined to leave it as it is in this PR unless someone else has problems.

requirements.txt can be freely modified now or in the future. It is meant as a convenience.

@qwofford
Copy link
Collaborator Author

Also resolves #86

Copy link
Collaborator

@jpulidojr jpulidojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the sqlite changes and this works.

My only concern is that the requirements.txt seems to be parquet specific and not DSI. do we want to withhold these? Otherwise we are significantly increasing the number of dependencies for the base DSI code.

Copy link
Collaborator

@jpulidojr jpulidojr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 89 will address the requirements.txt as a per-example addition to the code

@jpulidojr jpulidojr merged commit ea53877 into main Jan 25, 2024
@jpulidojr jpulidojr deleted the qwofford/issue81 branch February 22, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make default Parquet inspect_artifact method non-interactive.
2 participants