-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: Templated MD arrays #39
Open
mauneyc-LANL
wants to merge
21
commits into
main
Choose a base branch
from
mauneyc/templated_md
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f29eaf7
initial commit
7a8e259
spelling + comments
4c13c2c
added PORTABLE_ function preambles to missing ones
4742b0b
getting build/exec on GPUs
mauneyc-LANL 4bf821e
fix indexing
mauneyc-LANL 4863827
some design changes
mauneyc-LANL 1492a98
tests and benchmarks
36e848c
Merge branch 'main' into mauneyc/templated_md
551910b
store
9ab0b9b
merge
352077a
Merge branch 'main' into mauneyc/templated_md
0f66ba1
array and index algs
ece0a3c
comment cleanup and copyright
6668587
short comments in algos
825301a
removed unneeded parameter
703397a
some sloppy juggling of types
195fecf
working on stuff
f2431e1
add span
e64866d
merge main
3c769f2
undo span changes
9733f80
removed benchmark testing; fix some tests for gpu
mauneyc-LANL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the event of +kokkos~cuda, wouldn't this result in a compile error?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it, but POC doesn't have a
USE_CUDA
or similar likesingularity-eos
does, so I need to probe which compiler is being used.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is how I've done it in other projects: