Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update installation instructions #154
Update installation instructions #154
Changes from 30 commits
dcfaf1b
e9ff99e
ad6bb4d
4ba2057
f8d072e
bbca395
289dd38
462af6d
21e0f41
3c4e867
06f7b2c
393c5a1
d4be3b7
ec83acc
4103091
0dde201
b5a83bb
03c9a0c
36beca9
4711b17
b4f0cd3
e278182
3805e4e
4bc20c4
34ff9ac
c9ed61a
cbf811b
6a6b725
1ec4614
528c043
93694fb
75b666d
ce4da27
617e993
d2301b7
7d37a01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first sentence here seems to have been lost (rather than moved) in the edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it since it seemed that we are explaining why we need astra but not why we need the other example_requirements. Shall I add a few sentences to explain how we are using each of the example_requirements or just add back this sentence on astra?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point. I'm OK with leaving it as-is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we mention
astra
, perhapssvmbir
also deserves an explicit mention, despite being included in the requirements file?