Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to replace model in resource stub #272

Conversation

RobChatloop
Copy link
Contributor

To better support phpstan/code discoverability it would be ideal to expose the related model to the resource - this PR just moves the model replacement logic into a trait so that it can be shared by both the schema and resource commands.

I've then updated the resource stub accordingly 👍

@lindyhopchris lindyhopchris self-assigned this Mar 3, 2024
@lindyhopchris
Copy link
Contributor

Hi @RobChatloop - hope all is going well at Chatloop! It's Chris G from G4m here :-)

Thanks for the PR. I've updated the tests for the console command for your changes. Will squash merge this now and tag a release.

@lindyhopchris lindyhopchris merged commit be16a21 into laravel-json-api:develop Mar 3, 2024
3 checks passed
@RobChatloop
Copy link
Contributor Author

Cheers @lindyhopchris! Hey!!! Yeah it's nice to be using Laravel again and with some great tooling around 😉

@RobChatloop RobChatloop deleted the feat/model-in-resource-stub branch October 8, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants