Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the
eslint
&prettier
configurationChanges
Removed
yarn.lock
, there is already a package-lock.json file. In my opinion we should stick to a single package lock file, in previous pr's it has been mentioned yarn is not used.Removed
babel-eslint
from the devDependencies, it is unmaintained and replaced by the already present@babel/eslint-parser
. (Read about it here: https://www.npmjs.com/package/babel-eslint), this migration was already done in the eslint config (#28).Removed
eslint-plugin-prettier
from the devDependencies, the prettier and eslint teams recommend to use each tool separately. (https://prettier.io/docs/en/integrating-with-linters.html#eslint).A linter should be used for linting, a formatter for formatting. It also wasn't reporting any prettier errors to eslint. This behaviour is implemented by extending
eslint-config-prettier
.Removed
eslint-plugin-next
from the devDependencies,@next/eslint-plugin-next
, the plugin that powers the config is already present. Because we use a custom eslint config we implement the rules ourselves by extending that core plugin.Implemented the next recommended rules in the custom eslint config. This now correctly extends the
next
config and reports the correct errors.I also removed some unused code reported by eslint.
package.json
is not formatted according to theprettier
rules, along with a lot of the files in the repo. I'd love to runprettier --write .
but thats a maintainer decision 😅