Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.x] Cleanup and add feature tests #1767

Merged

Conversation

hafezdivandari
Copy link
Contributor

@hafezdivandari hafezdivandari commented Jul 4, 2024

This PR does some cleanup to make the upcoming PR easy to review.

  • Cleanup PersonalAccessTokenFactory class - makes reviewing the upcoming PR easier.
  • Cleanup ClientRepository class and remove redundant methods.
  • Add a feature test and remove a unit test.

Copy link

github-actions bot commented Jul 4, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@hafezdivandari hafezdivandari marked this pull request as ready for review July 4, 2024 14:37
@taylorotwell taylorotwell merged commit 4ffc542 into laravel:13.x Jul 4, 2024
7 checks passed
@hafezdivandari hafezdivandari deleted the 13.x-respect-pat-guard-provider branch July 4, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants