Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MySQL container issue in Playwright E2E tests #2544

Closed
wants to merge 2 commits into from

Conversation

ryota-murakami
Copy link
Collaborator

@ryota-murakami ryota-murakami commented Jun 14, 2024

Related to #2543

Implements health checks and logging for MySQL container and updates GitHub Actions workflows to ensure E2E tests pass without MySQL container issues.

  • MySQL Container Configuration: Adds a health check to the MySQL service in compose.yml to ensure it's fully operational before proceeding with tests. Also, updates logging options to capture more detailed information for debugging purposes.
  • Playwright Test Configuration: Introduces a pre-test hook in playwright.config.ts to check the health of the MySQL container and ensure connectivity. Adjusts the webServer configuration to wait for the MySQL container to be fully operational before starting tests.
  • GitHub Actions Workflows: Updates the workflows for admin, selfhost, and visitor tests (playwright_admin.yml, playwright_selfhost.yml, playwright_visitor.yml) to include a step for logging the status of the MySQL container before running tests. This step aims to provide insights into the MySQL container's state, aiding in troubleshooting and ensuring test reliability.

For more details, open the Copilot Workspace session.

@ryota-murakami
Copy link
Collaborator Author

Add logging for MySQL container status and improve container health checks.

  • Introduces logging commands in GitHub Actions workflows (playwright_admin.yml, playwright_selfhost.yml, playwright_visitor.yml) to log the MySQL container status, enhancing debugging capabilities.
  • Implements a health check for the MySQL container in compose.yml, ensuring the container is ready before proceeding with tests.
  • Adjusts logging settings for the MySQL container to limit log file size and number, preventing excessive disk usage.
  • Adds a custom event listener in playwright.config.ts to log when the MySQL container is ready, improving feedback during test execution.

For more details, open the Copilot Workspace session.

Add logging for MySQL container status and improve container health checks.

- Introduces logging commands in GitHub Actions workflows (`playwright_admin.yml`, `playwright_selfhost.yml`, `playwright_visitor.yml`) to log the MySQL container status, enhancing debugging capabilities.
- Implements a health check for the MySQL container in `compose.yml`, ensuring the container is ready before proceeding with tests.
- Adjusts logging settings for the MySQL container to limit log file size and number, preventing excessive disk usage.
- Adds a custom event listener in `playwright.config.ts` to log when the MySQL container is ready, improving feedback during test execution.


---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/laststance/nsx/pull/2544?shareId=e2765ad6-024f-4a23-91a9-5d981918c2df).
@ryota-murakami ryota-murakami deleted the ryota-murakami/fix-mysql-issue branch June 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant