Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numerous \DeclareFontSeriesChangeRule entries #1396

Open
wants to merge 29 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
86d2391
Delete duplicate lines
user227621 Jun 28, 2024
461367a
Rearrange the rules for 'm?' and '?m'
user227621 Jun 28, 2024
0ae2436
Correct two rules involving 'ub'
user227621 Jun 28, 2024
974c905
Add rules for 'm?'/'?m' with the widths 'uc', 'sx', 'ex', 'ux'
user227621 Jun 28, 2024
f21b4ac
Delete duplicate blank line
user227621 Jun 28, 2024
9a89d15
Rearrange the \DeclareFontSeriesChangeRule rules
user227621 Jun 28, 2024
9cfecdc
Unify the use of spaces
user227621 Jun 28, 2024
d941eb7
Rearrange the \DeclareFontSeriesChangeRule blocks
user227621 Jun 28, 2024
b1e6932
Delete three unnecessary rules
user227621 Jun 28, 2024
8409ee4
Add numerous \DeclareFontSeriesChangeRule rules. Now the full range o…
user227621 Jun 28, 2024
cdafc41
Provide an alternative target series for some rules (in cases where s…
user227621 Jun 28, 2024
508b779
Delete some '?' comments
user227621 Jun 28, 2024
3f3d61c
Update the description of rules
user227621 Jul 1, 2024
5cdb0a4
Delete five rules
user227621 Jul 1, 2024
b68f461
Number of rules has changed
user227621 Jul 1, 2024
61771ff
Delete four rules
user227621 Jul 1, 2024
89ebbf7
Delete four alternative target series
user227621 Jul 1, 2024
547e40e
spaces
user227621 Jul 1, 2024
034151f
Update changes.txt
user227621 Jul 1, 2024
f9d8423
Update date and version
user227621 Jul 1, 2024
143d760
\changes entries
user227621 Jul 1, 2024
0e86888
Minor rewording
user227621 Jul 1, 2024
1c1d493
missing space
user227621 Jul 1, 2024
d6231e1
typos
user227621 Jul 3, 2024
58a6014
Add further explanations
user227621 Jul 3, 2024
611a2e2
Minor changes to the documentation
user227621 Jul 3, 2024
1db4720
comma
user227621 Jul 24, 2024
549a597
ltnews entry added
user227621 Jul 24, 2024
1ed3507
Rephrase incomplete sentence
user227621 Jul 24, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions base/ltfssaxes.dtx
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,9 @@
% The rules set up use explicit series values not \cs{..default}
% indirections; my current feeling is that this is in fact better.
%
% With 9 weights and 9 width classes this table is getting a bit large
% in the end (324 entries) but on the other hand it doesn't change and
% With 9 weight values (from \texttt{ul} to \texttt{ub}) and 9 width values
% (from \texttt{uc} to \texttt{ux}), this table is getting a bit large in
% the end (1345 entries), but on the other hand it doesn't change and
% accessing speed and it is fast this way.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An incomplete sentence: "but on the other hand it doesn't change and accessing speed and it is fast this way." What was that originally supposed to mean?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@user227621

I assume the intended meaning is along the lines of this, which might be clearer?

this table is now rather large (1345 entries), but on the other hand, the table doesn't change and accessing rules is fast using a table implemented in this way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have rephrased the sentence accordingly.

%
% We could alternatively split the axis and maintain weight and width
Expand All @@ -147,30 +148,40 @@
%
% We make \texttt{m} to reset both weight and width (as this is
% how it always worked). To reset just the width \texttt{?m} is
% provided and to reset just the weight \texttt{m?}.
% provided and to reset just the weight \texttt{m?} is provided.
%
% \item
%
% We do support ``\texttt{m}\textit{width}'' and
% We do support ``\texttt{m}\textit{width}'' and
% ``\textit{weight}\texttt{m}'', e.g., \texttt{mec} to mean ``go to
% medium weight and extra-condensed width''. At the end of the
% process we automatically drop any leftover \texttt{m} in the
% series name (unless it is just a single \texttt{m}).
%
%
% \item
%
% If there is no table entry then the target series is used
% unconditionally. This means that any request to set both weight
% and width (e.g. \texttt{bx} or \texttt{ulc}) needs no table
% entries.
% For that reason there are no entries which have a weight+width as
% request (i.e., second argument).
% unconditionally. This means that we usually do not need entries
% where the second and third arguments are identical (unless we want
% to use the fourth argument to specify an alternative target series).
% In particular, this means:
% \begin{itemize}
% \item
%
% Any request for \texttt{m} needs no entry, i.e. there are no entries
% which have \texttt{m} as second argument.
%
% In particular this is also true for cases involving \texttt{m},
% e.g., \texttt{bm} (bold medium width) which automatically gets
% reduced result in \texttt{b} or \texttt{mc} (medium weight
% condensed) which becomes \texttt{c} as a result.
% \item
%
% Any request to set both weight and width (e.g. \texttt{bx} or
% \texttt{ulc}) needs no entry. For that reason, there are no entries
% which have a weight+width as second argument (except for a few
% cases where the fourth argument is used to specify an alternative
% target series). In particular this is also true for cases involving
% \texttt{m}, e.g. \texttt{bm} (bold medium width) which
% automatically gets reduced to \texttt{b} or \texttt{mc} (medium
% weight condensed) which becomes \texttt{c} as a result.
% \end{itemize}
%
% \item
%
Expand All @@ -185,16 +196,6 @@
% shape to \texttt{n} and then find that \texttt{bc/n} doesn't
% exist either and thus ending up with \texttt{m/n}.
%
% \item
%
% Also: while I did set up all nine standard weight values from
% \texttt{ul} to \texttt{ub} I only bothered to provide entries for
% \texttt{ec}, \texttt{sc}, \texttt{c} and \texttt{x}, because other levels of
% compression/expansion are not in any real fonts that I know.
%
% Could and perhaps should be eventually extended to cover the
% whole set.
%
% \end{itemize}
%
% \begin{macrocode}
Expand Down