Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose asyncWithLDProvider from the React SDK #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stoutatnerdery
Copy link

Requirements

  • I have added test coverage for new or changed functionality
  • I have followed the repository's pull request submission guidelines
  • I have validated my changes against all supported platform versions

Related issues

N/A

Describe the solution you've provided

Exposes asyncWithLDProvider, from the React SDK. This can be useful when trying to avoid flashes of content. See LaunchDarkly docs here and here.

Describe alternatives you've considered

N/A

Additional context

N/A

@stoutatnerdery stoutatnerdery requested a review from a team January 5, 2024 20:17
@jordan-massingill
Copy link

Would love to be able to use this 🙏

@yusinto
Copy link
Collaborator

yusinto commented May 31, 2024

This plugin uses withLDProvider to initialize the React SDK under the hood. ExposingasyncWithLDProvider will not change this behavior. It is a good suggestion though to support asyncWithLDProvider in addition to the withLDProvider. This sounds like a feature request because it involves adding a new option to configure the plugin to use the async function. I have filed this request internally as 246055.

In the meantime, it's possible to use the React SDK directly in your gatsby app to achieve this. So I propose you can use that as a workaround for now.

@yusinto yusinto added the enhancement New feature or request label May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants