FEAT: Return headers of connection start #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Dario, thank you for the PR! Due to time constraints, we might be a bit slow in reviewing and/or merging this at the moment. Filed internally as 178073. |
|
@Zarathustra2 thank you for your patience. Both you and another developer have contributed PRs providing some similar behavior. I have merged your work, along with theirs, into a new PR (#79) and included some adjustments we would also like to make. I'm going to close this PR and keep all communication focused on that new PR. Once again, thank you for your contribution and I look forward to hearing if this new PR works for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Noticed there was no way to access the headers from the connection creation so I added that in.
The use case here is that we connect that our providers adds a session cookie in the headers which we need to extract to update the stream (add/remove subscriptions)
Best regards,
Dario