Skip to content

Commit

Permalink
fix: Bump MSRV to 1.70.0 (#61)
Browse files Browse the repository at this point in the history
Co-authored-by: Casey Waldren <[email protected]>
  • Loading branch information
keelerm84 and cwaldren-ld authored Dec 20, 2023
1 parent 8c16e46 commit 3a4d8e7
Show file tree
Hide file tree
Showing 6 changed files with 12 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:

- name: Setup rust tooling
run: |
rustup override set 1.68
rustup override set 1.70
rustup component add rustfmt clippy
- uses: ./.github/actions/ci
Expand All @@ -47,7 +47,7 @@ jobs:

- name: Setup rust tooling
run: |
rustup override set 1.68
rustup override set 1.70
rustup component add rustfmt clippy
rustup target add x86_64-unknown-linux-musl
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:

- name: Setup rust tooling
run: |
rustup override set 1.68
rustup override set 1.70
rustup component add rustfmt clippy
- uses: ./.github/actions/ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Setup rust tooling
if: ${{ steps.release.outputs.releases_created }}
run: |
rustup override set 1.68
rustup override set 1.70
rustup component add rustfmt clippy
- uses: launchdarkly/gh-actions/actions/[email protected]
Expand Down
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@ cargo run --example EXAMPLE_NAME

Read our [documentation](https://docs.launchdarkly.com) for in-depth instructions on configuring and using LaunchDarkly. You can also head straight to the [complete reference guide for this SDK](https://docs.launchdarkly.com/sdk/server-side/rust).

## Minimum Supported Rust Version

This project aims to maintain compatibility with a Rust version that is at least six months old.

Version updates may occur more frequently than the policy guideline states if external forces require it. For example, a CVE in a downstream dependency requiring an MSRV bump would be considered an acceptable reason to violate the six month guideline.

## Testing

We run integration tests for all our SDKs using a centralized test harness. This approach gives us the ability to test for consistency across SDKs, as well as test networking behavior in a long-running application. These tests cover each method in the SDK, and verify that event sending, flag evaluation, stream reconnection, and other aspects of the SDK all behave correctly.
Expand Down
2 changes: 1 addition & 1 deletion contract-tests/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
name = "contract-tests"
version = "0.1.0"
edition = "2021"
rust-version = "1.68.0" # MSRV
rust-version = "1.70.0" # MSRV
license = "Apache-2.0"

[dependencies]
Expand Down
2 changes: 1 addition & 1 deletion launchdarkly-server-sdk/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description = "LaunchDarkly Server-Side SDK"
version = "2.0.1"
authors = ["LaunchDarkly"]
edition = "2021"
rust-version = "1.68.0" # MSRV
rust-version = "1.70.0" # MSRV
license = "Apache-2.0"
homepage = "https://docs.launchdarkly.com/sdk/server-side/rust"
repository = "https://github.com/launchdarkly/rust-server-sdk"
Expand Down

0 comments on commit 3a4d8e7

Please sign in to comment.