Pass ignore SSL option to Guzzle #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
First iteration without documentation. Looking for direction on whether this is the right way to go. |
laupiFrpar
approved these changes
Mar 7, 2023
|
@dpi Hello, I think that is the good way to start. Maybe in the second time, we could configure the Guzzle client in the config. That is maybe a little complex to set in the configuration. Thank you for your work! Let me know when you finish this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally opt into customising Guzzle client, specifically allowing configurations to opt out of SSL certificate validation per https://docs.guzzlephp.org/en/stable/request-options.html#verify
For example when running Soketi with SSL, it seems to force it into only responding via SSL.
When accessed on a private network, the Soketi service may be accessed differently/without SSL/with a different hostname. So it may make sense to ignore whatever cert is returned by Soketi.