This repository has been archived by the owner on Apr 22, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 77
Add CI via Github Actions #267
Open
MCOfficer
wants to merge
109
commits into
laurent-clouet:master
Choose a base branch
from
MCOfficer:actions
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected and clarified the 'MISSING RENDER' error case.
When passed as inline parameters, memory is expressed as MB. However, when passed in a config file, memory was expressed as KB. This created confusion https://discordapp.com/channels/253355867938750485/301912419368697856/541719192252973066 https://discordapp.com/channels/253355867938750485/301912419368697856/541719244094701597 https://discordapp.com/channels/253355867938750485/301912419368697856/541719343684124696
Make config file loader take ram in MB for consistency
clarification of error message
Fix Ant Build
… allow by scheduler depending on the past error, current settings (ram, cpu, gpu,...)
Fix grammar and consistency of README
… anymore, it should be removed
The text UI gets quite messy during the render process, as it takes at least one extra line of the screen per second. This PR fixes that issue and also shows an ASCII bar to show the render progress.
tuxun
reviewed
Jul 21, 2020
tuxun
approved these changes
Jul 21, 2020
tuxun
approved these changes
Jul 21, 2020
tuxun
approved these changes
Jul 21, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea and PR is very nicely made.
tuxun
approved these changes
Jul 21, 2020
svn_trunk_url="https://github.com/laurent-clouet/sheepit-client/trunk" | ||
pwd=`pwd` | ||
tmp_dir=`mktemp -d` | ||
jvm_name="jdk-11.0.6+10-jre" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this jvm version match the one declared in ci.yml via its /usr/lib/jvm/ root dir?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not required, JVM major versions are bytecode-compatible.
laurent-clouet
force-pushed
the
master
branch
2 times, most recently
from
October 21, 2020 11:09
90c3325
to
7f1949e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an action run that generates a signed .jar and .exe on every commit.
In order to make the CI use your certificate, you need to:
keystore.gpg
with it. See steps 1-4CERT_ALIAS
- your certificate's alias in the keystoreKEYSTORE_ENCRYPTION_PASS
- the passphrase used to encrypt the keystoreKEYSTORE_PASS
- the keystore's password