Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Feature: make stats and last rendered frame panels collapsible #292

Open
wants to merge 120 commits into
base: master
Choose a base branch
from

Conversation

luguina
Copy link
Collaborator

@luguina luguina commented Sep 5, 2020

The visual footprint of the client is quite big (520x800 px). This PR allows the use to collapse/expand any of the Global stats, Session infos and Last uploaded frame panels to reduce the vertical visual footprint.

Screenshot (with all panels collapsed)
image

Tehrasha and others added 30 commits January 28, 2019 02:07
Corrected and clarified the 'MISSING RENDER' error case.
Make config file loader take ram in MB for consistency
… allow by scheduler depending on the past error, current settings (ram, cpu, gpu,...)
Fix grammar and consistency of README
luguina and others added 17 commits June 21, 2020 11:15
…et#256)

* Fix: -renderbucket-size option not applied if configuration file doesn't exist
* Include public key as password in help
* Fix failed MimeType detection

* Fix failed MimeType detection

* Fix formatting
…tain time (laurent-clouet#249)

A new -shutdown <time> option has been created to specify the time when the client will stop asking for new jobs, will finish uploading the frames in the upload queue and will shutdown the computer. The time argument can have two different formats: an absolute date & time in the format yyyy-MM-ddThh:mm:ss (24h format) or a relative time in the format +m where m is the number of minutes from now.

The user can also select the shutdown-mode, where "wait" will wait for all the processes (render + pending uploads) to finish and "hard" will cancel all the pending jobs and will initiate the computer shutdown.
…t#282)

* restore missing time remaining time in UI with openCL
@laurent-clouet
Copy link
Owner

As a user i like to have my choice saved from the session to another.

@luguina
Copy link
Collaborator Author

luguina commented Sep 9, 2020

As a user i like to have my choice saved from the session to another.

I agree @laurent-clouet but this is MVP. We can deliver to the users a feature that is useful and covers 90% of the expected functionality. We can add saving the user preference between sessions in a future weekly release.
The reason why is not included in the current version is that the existing configuration lifecycle became messy with time and the code needs a serious refactoring. It's not developer friendy and prone to mistakes. I have started the task of rebuilding from scratch the whole configuration process/saving to make it easier in the future. As soon as it's finished we can easily add a couple of lines to save the state between sessions (and many others -thinking in Window position).

gatewaytofredom and others added 2 commits September 11, 2020 14:11
…urent-clouet#287)

* Feature: add session data consumption information in GUI/text UIs

Adds the total bytes downloaded and uploaded in the current session as well as the average data transfer rate for both UL/DL. The information is not added to the 1-line UI as the line will take 150+ characters in the screen.
@laurent-clouet
Copy link
Owner

On my ubuntu20.04 with kde i have an issue when i launch the client.
image

Once i click on it, it extends to the maximum side and them i can collapse if needed.

@luguina luguina force-pushed the feature/working-panels-collapsible branch from 3c49861 to edae180 Compare September 12, 2020 00:14
@luguina
Copy link
Collaborator Author

luguina commented Sep 12, 2020

On my ubuntu20.04 with kde i have an issue when i launch the client.
image

Once i click on it, it extends to the maximum side and them i can collapse if needed.

You mean the top Project panel where lines seem to be closer than the rest? Can you check the new version that I just pushed with the new master rebased?

@laurent-clouet
Copy link
Owner

laurent-clouet commented Sep 28, 2020

I tested on a different machine on win10, i have the same issue with the newer version.
image

I click on anywhere on the window, it expends to the "regular" screen (about 800px height).

@tuxun
Copy link
Contributor

tuxun commented Oct 20, 2020

Hi,
@luguina Thanks for PR, its a feature i will definitively use!

I was wondering, on the user setting panel, we already can collapse panels, is it more or less the same implementation?

@laurent-clouet I guess you have this problem in the actual setting tab (already using collapsible panel on stable version of client)?

@luguina
Copy link
Collaborator Author

luguina commented Oct 21, 2020

Hi,
@luguina Thanks for PR, its a feature i will definitively use!

I was wondering, on the user setting panel, we already can collapse panels, is it more or less the same implementation?

Thanks @tuxun. It uses the same implementation of collapsible panels you have in the Settings. The difference is the current client has a fixed size and this PR "calculates" the correct size based on the status of the panels (collapsed/opened). Because the Swing events work (working much better with modern UI libraries like JavaFX), is not until you put the focus in the application window when the proper measurement is done. That's why the initial instantiation of the app doesn't properly calculate the layout and "compress" the information but when you select the window it's calculated properly.

I think I have a way of working around the problem and will try tonight. Stay tuned!

@laurent-clouet laurent-clouet force-pushed the master branch 2 times, most recently from 90c3325 to 7f1949e Compare October 21, 2020 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.