Skip to content
This repository has been archived by the owner on Apr 22, 2021. It is now read-only.

Feature: enable low-bandwidth mode from the settings screen #293

Open
wants to merge 116 commits into
base: master
Choose a base branch
from

Conversation

luguina
Copy link
Collaborator

@luguina luguina commented Sep 6, 2020

This feature allows the user to activate the low-bandwidth mode from the settings GUI screen.

Tehrasha and others added 30 commits January 28, 2019 02:07
Corrected and clarified the 'MISSING RENDER' error case.
Make config file loader take ram in MB for consistency
… allow by scheduler depending on the past error, current settings (ram, cpu, gpu,...)
Fix grammar and consistency of README
luguina and others added 22 commits June 18, 2020 13:57
)

* Fix: Send reset signal to server on job upload error
…et#256)

* Fix: -renderbucket-size option not applied if configuration file doesn't exist
* Include public key as password in help
* Fix failed MimeType detection

* Fix failed MimeType detection

* Fix formatting
…tain time (laurent-clouet#249)

A new -shutdown <time> option has been created to specify the time when the client will stop asking for new jobs, will finish uploading the frames in the upload queue and will shutdown the computer. The time argument can have two different formats: an absolute date & time in the format yyyy-MM-ddThh:mm:ss (24h format) or a relative time in the format +m where m is the number of minutes from now.

The user can also select the shutdown-mode, where "wait" will wait for all the processes (render + pending uploads) to finish and "hard" will cancel all the pending jobs and will initiate the computer shutdown.
…t#282)

* restore missing time remaining time in UI with openCL
@luguina luguina changed the title Feature: enable low-bandwidth mode from setting screen Feature: enable low-bandwidth mode from the settings screen Sep 6, 2020
@laurent-clouet
Copy link
Owner

I'm not sure it's the best way to do that feature because the scheduler option is only available on config request so only at the beginning of the session.
Maybe we should put the option on the request_job request...

@luguina luguina closed this Sep 9, 2020
@luguina luguina reopened this Sep 9, 2020
@luguina
Copy link
Collaborator Author

luguina commented Sep 9, 2020

I don't see the problem here, TBH. Many applications show this behaviour when you're changing an option that cannot be applied in runtime. Even in the current client, we have the same behaviour in the No Systray option. It requires a client restart to be applied.

@luguina
Copy link
Collaborator Author

luguina commented Sep 9, 2020

Maybe we should put the option on the request_job request...

I think the logical place is the configuration call (the one you decided) because is quite unlikely that your configuration will change during a session (moving from low bandwidth to normal or vice-versa), but if restarting the client to apply the new configuration is a serious roadblock for you then we can move it to the request job call to make it dynamic.

@laurent-clouet laurent-clouet force-pushed the master branch 2 times, most recently from 90c3325 to 7f1949e Compare October 21, 2020 11:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.